Update LKG #32578
Merged
Update LKG #32578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested review from
sandersn,
DanielRosenwasser,
rbuckton and
RyanCavanaugh
rbuckton
approved these changes
Jul 27, 2019
WORMSS
reviewed
Oct 8, 2019
| @@ -22,8 +22,8 @@ and limitations under the License. | |||
| /// ECMAScript APIs | |||
| ///////////////////////////// | |||
|
|
|||
| declare const NaN: number; | |||
| declare const Infinity: number; | |||
| declare var NaN: number; | |||
There was a problem hiding this comment.
I am just wondering on the reason for changing const to var in .d.ts files ? @weswigham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can start using the better generator types in our own codebase, rather than the hand-rolled psuedogenerator types we currently use.